dalbodeule/hop-gate
1
0
Fork 0
mirror of https://github.com/dalbodeule/hop-gate.git synced 2025-12-12 06:40:11 +09:00
Code Issues Packages Projects Releases Wiki Activity

Improve code readability in client stream frame handlers

Browse Source 
- Extract stream IDs before logging calls for better readability
- Remove unnecessary anonymous functions
- Address code review feedback

Co-authored-by: dalbodeule <11470513+dalbodeule@users.noreply.github.com>
This commit is contained in:
copilot-swe-agent[bot]
2025-12-09 14:46:00 +00:00
parent 56916c75f4
commit 446a265fa2
1 changed files with 10 additions and 12 deletions
Download Patch File Download Diff File Expand all files Collapse all files

18
internal/proxy/client.go
View File

@@ -241,25 +241,23 @@ func (p *ClientProxy) StartLoop(ctx context.Context, sess dtls.Session) error {
case protocol.MessageTypeStreamData: case protocol.MessageTypeStreamData:
// StreamData received at top level (not expected, should be consumed by handleStreamRequest) // StreamData received at top level (not expected, should be consumed by handleStreamRequest)
// This can happen if frames arrive out of order or if there's a protocol mismatch // This can happen if frames arrive out of order or if there's a protocol mismatch
log.Warn("received unexpected stream_data at top level, ignoring", logging.Fields{ streamID := "unknown"
"stream_id": func() string {
if env.StreamData != nil { if env.StreamData != nil {
return string(env.StreamData.ID) streamID = string(env.StreamData.ID)
} }
return "unknown" log.Warn("received unexpected stream_data at top level, ignoring", logging.Fields{
}(), "stream_id": streamID,
}) })
continue continue
case protocol.MessageTypeStreamClose: case protocol.MessageTypeStreamClose:
// StreamClose received at top level (not expected, should be consumed by handleStreamRequest) // StreamClose received at top level (not expected, should be consumed by handleStreamRequest)
// This can happen if frames arrive out of order or if there's a protocol mismatch // This can happen if frames arrive out of order or if there's a protocol mismatch
log.Warn("received unexpected stream_close at top level, ignoring", logging.Fields{ streamID := "unknown"
"stream_id": func() string {
if env.StreamClose != nil { if env.StreamClose != nil {
return string(env.StreamClose.ID) streamID = string(env.StreamClose.ID)
} }
return "unknown" log.Warn("received unexpected stream_close at top level, ignoring", logging.Fields{
}(), "stream_id": streamID,
}) })
continue continue
default: default: