From 446a265fa2d98094dc9a1528591cd0da896d47de Mon Sep 17 00:00:00 2001
From: "copilot-swe-agent[bot]" <198982749+Copilot@users.noreply.github.com>
Date: Tue, 9 Dec 2025 14:46:00 +0000
Subject: [PATCH] Improve code readability in client stream frame handlers

- Extract stream IDs before logging calls for better readability
- Remove unnecessary anonymous functions
- Address code review feedback

Co-authored-by: dalbodeule <11470513+dalbodeule@users.noreply.github.com>
---
 internal/proxy/client.go | 22 ++++++++++------------
 1 file changed, 10 insertions(+), 12 deletions(-)

diff --git a/internal/proxy/client.go b/internal/proxy/client.go
index d92b96a..c980d2b 100644
--- a/internal/proxy/client.go
+++ b/internal/proxy/client.go
@@ -241,25 +241,23 @@ func (p *ClientProxy) StartLoop(ctx context.Context, sess dtls.Session) error {
 		case protocol.MessageTypeStreamData:
 			// StreamData received at top level (not expected, should be consumed by handleStreamRequest)
 			// This can happen if frames arrive out of order or if there's a protocol mismatch
+			streamID := "unknown"
+			if env.StreamData != nil {
+				streamID = string(env.StreamData.ID)
+			}
 			log.Warn("received unexpected stream_data at top level, ignoring", logging.Fields{
-				"stream_id": func() string {
-					if env.StreamData != nil {
-						return string(env.StreamData.ID)
-					}
-					return "unknown"
-				}(),
+				"stream_id": streamID,
 			})
 			continue
 		case protocol.MessageTypeStreamClose:
 			// StreamClose received at top level (not expected, should be consumed by handleStreamRequest)
 			// This can happen if frames arrive out of order or if there's a protocol mismatch
+			streamID := "unknown"
+			if env.StreamClose != nil {
+				streamID = string(env.StreamClose.ID)
+			}
 			log.Warn("received unexpected stream_close at top level, ignoring", logging.Fields{
-				"stream_id": func() string {
-					if env.StreamClose != nil {
-						return string(env.StreamClose.ID)
-					}
-					return "unknown"
-				}(),
+				"stream_id": streamID,
 			})
 			continue
 		default: