dalbodeule/hop-gate
1
0
Fork 0
mirror of https://github.com/dalbodeule/hop-gate.git synced 2025-12-08 04:45:43 +09:00
Code Issues Packages Projects Releases Wiki Activity

[fix](errorpages): refine error page handling and resolve template issues

Browse Source 
- Replaced unused `logo.svg` reference with `hop-gate.png` in embedded assets.
- Fixed redundant code for reading files from the error page directory.
- Updated 400 error template to properly reference external Tailwind CSS.
- Corrected invalid DOCTYPE declaration in 525 error template.
This commit is contained in:
dalbodeule
2025-12-02 22:07:22 +09:00
parent 0c4e02f832
commit 9bb0d0d009
3 changed files with 8 additions and 9 deletions
Download Patch File Download Diff File Expand all files Collapse all files

13
internal/errorpages/errorpages.go
View File

@@ -22,7 +22,8 @@ var embeddedTemplatesFS embed.FS
// //
// Expected files (by convention): // Expected files (by convention):
// - assets/errors.css // - assets/errors.css
// - assets/logo.svg // - assets/hop-gate.png
//
//go:embed assets/* //go:embed assets/*
var AssetsFS embed.FS var AssetsFS embed.FS
@@ -67,16 +68,14 @@ func Load(status int) ([]byte, bool) {
if dir == "" { if dir == "" {
dir = "./errors" dir = "./errors"
} }
if dir != "" { p := filepath.Join(dir, name)
p := filepath.Join(dir, name) if data, err := os.ReadFile(p); err == nil {
if data, err := os.ReadFile(p); err == nil { return data, true
return data, true
}
} }
// 2. Embedded default templates. // 2. Embedded default templates.
// 2. 내장 기본 템플릿. // 2. 내장 기본 템플릿.
p := filepath.Join("templates", name) p = filepath.Join("templates", name)
if data, err := embeddedTemplatesFS.ReadFile(p); err == nil { if data, err := embeddedTemplatesFS.ReadFile(p); err == nil {
return data, true return data, true
} }

2
internal/errorpages/templates/400.html
View File

@@ -4,7 +4,7 @@
<meta charset="utf-8"> <meta charset="utf-8">
<title>400 Bad Request - HopGate</title> <title>400 Bad Request - HopGate</title>
<meta name="viewport" content="width=device-width, initial-scale=1"> <meta name="viewport" content="width=device-width, initial-scale=1">
<!-- Tailwind build output should be bundled into this file --> <!-- Tailwind CSS is served separately from /__hopgate_assets__/errors.css -->
<link rel="stylesheet" href="/__hopgate_assets__/errors.css"> <link rel="stylesheet" href="/__hopgate_assets__/errors.css">
</head> </head>
<body class="min-h-screen bg-slate-950 text-slate-50 flex items-center justify-center px-4"> <body class="min-h-screen bg-slate-950 text-slate-50 flex items-center justify-center px-4">

2
internal/errorpages/templates/525.html
View File

@@ -1,4 +1,4 @@
ㄱ<!DOCTYPE html> <!DOCTYPE html>
<html lang="en"> <html lang="en">
<head> <head>
<meta charset="utf-8"> <meta charset="utf-8">